[
https://issues.apache.org/jira/browse/MYFACES-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899010#action_12899010
]
Leonardo Uribe commented on MYFACES-2774:
-----------------------------------------
Hi Marius
I found another error on the test, so I attached another patch. It always
should reference if2.xhtml. The components that render start and end should be
preserved. The assertion is fine. Think about it: why "start" and "end"
dissapear after beign applied? Try the test but without apply the solution and
you'll see in this way it pass. Now apply the remainig changes and the test
fails.
> Remove MARK_DELETED attribute from the component
> ------------------------------------------------
>
> Key: MYFACES-2774
> URL: https://issues.apache.org/jira/browse/MYFACES-2774
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General, JSR-314
> Affects Versions: 2.0.0
> Reporter: Marius Petoi
> Priority: Minor
> Attachments: markDeletedFaceletContext.patch,
> markDeletedFaceletContext2.patch, markDeletedFaceletContext3.patch,
> markDeletedFaceletContext4.patch, markDeletedFaceletContext5.patch,
> markDeletedFaceletContext6.patch, markDeletedFaceletContext7.patch,
> markDeletedFaceletContext8.patch
>
>
> The ComponentSupport.MARK_DELETED attribute is used only inside one request.
> It doesn't need to be saved in the state. It should be removed from the
> attributes of the component. Instead a list of components marked for deletion
> should be included in the FaceletContext.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
