[ 
https://issues.apache.org/jira/browse/TOMAHAWK-1532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leonardo Uribe resolved TOMAHAWK-1532.
--------------------------------------

    Fix Version/s: 1.1.10-SNAPSHOT
       Resolution: Fixed

> Do not include t:dojoInitializer in tomahawk for jsf 2.0
> --------------------------------------------------------
>
>                 Key: TOMAHAWK-1532
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1532
>             Project: MyFaces Tomahawk
>          Issue Type: Task
>          Components: JSF2
>    Affects Versions: 1.1.9
>            Reporter: Leonardo Uribe
>            Assignee: Leonardo Uribe
>             Fix For: 1.1.10-SNAPSHOT
>
>
> The reasons why don't include t:dojoInitializer are:
> 1. This component uses dojo v 0.4.1 and that is an old build. The latest 
> version of dojo is 1.5. Many things have changed since that time, so it is 
> very, very, very difficult to upgrade it, because many big refactors has been 
> done from that time.
> 2. The new jsf 2.0 Resource api does not play well with dojo modules loading. 
> To keep this working it is required to keep used tomahawk AddResource api, 
> because it is possible to use dojo.registerModulePath to redirect to other 
> modules properly. Note jsf 2.0 Resource api uses query params 
> (myfile.js.jsf?library=org.apache.....) and we cannot override dojo.require 
> without a nasty hack.
> 3. There exists a jsf library using dojo (http://www.dojofaces.org/) under 
> ASL and we don't want to duplicate work.
> In the future, components that used dojo in tomahawk sandbox should be redone 
> using myfaces core javascript if possible. Maybe in this case it is better to 
> refactor them in composite components like it was done with t:inputHtml.
> If no objections I'll commit the changes proposed soon.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to