[
https://issues.apache.org/jira/browse/MYFACES-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917456#action_12917456
]
Leonardo Uribe commented on MYFACES-2935:
-----------------------------------------
I committed two new fixes:
1. The order of added clientIds is critical to restore the tree properly (the
tests done before 2.0.2 were too simple to detect this precondition, but we
have to take that into account and construct that list when view is being
saved).
2. A ConcurrentModificationException is thrown when we remove components,
because we are manipulating the removed clientids list without real need, so we
need a check for that condition. The order for removed clientIds does not
matter in this case, but anyway use a Set for remove duplicates is ok.
Some junit tests were added to, based on the proposed tests. Now myfaces pass
4/4 tests.
> SystemEvent Acid Test
> ---------------------
>
> Key: MYFACES-2935
> URL: https://issues.apache.org/jira/browse/MYFACES-2935
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.2
> Reporter: Kennard Consulting
> Attachments: EventTest.myfaces.4.zip, EventTest.myfaces.zip
>
>
> Hi guys,
> First - thanks for the great work you do with MyFaces. It's an awesome
> product and it's wonderful to have an independent implementation of the JSF
> spec!
> I am the author of Metawidget (http://metawidget.org), a JSF component that
> does a lot of runtime component tree manipulation. This was unreliable under
> JSF 1, but JSF 2 introduced SystemEvents which promise to make this more
> solid. I believe Metawidget exercises SystemEvents more than most, and as
> such I am seeing problems both in MyFaces (2.0.2) and in Mojarra (2.0.3).
> As a bit of fun I have created a small Acid Test (inspired by
> http://acidtests.org) for SystemEvents. I would be most grateful if you could
> work through the 3 tests and get MyFaces working with them. Basically the
> tests all use a combination of PreRenderViewEvent and tree manipulation. Full
> instructions are included on each JSF page. Of course, there may be bugs in
> the test itself in which case feel free to point them out :)
> Regards,
> Richard.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
