[
https://issues.apache.org/jira/browse/MYFACES-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922844#action_12922844
]
Ivan commented on MYFACES-2945:
-------------------------------
Just some ideas for the integration improvment, please help to give some
comments.
a. Create a new SPI provider and a provider factory, might name
FacesConfigurationProvider/FacesConfigurationProviderFactory, which has a method
FacesConfig getFacesConfig(ExternalContext context);
This method is designed to get the final combined the FacesConfig instance,
which including application resource configuration + annotation + default web
application resource
And move those logic about merge/annotaiton scanning from FacesConfigurator
and AnnotationConfigurator to the default implementation provider
b. Make some classes in the org.apache.myfaces.config.impl.digester.elements
package serializable, this might be optional...
>From the integration side, the third-party container could implement their own
>FacesConfigurationProvider, they might return the FacesConfig object directly
>from their own structure.
c. I saw some codes in the ***ProviderFactory is commented out,
//AnnotationProviderFactory instance = (AnnotationProviderFactory)
ctx.getApplicationMap().get(FACTORY_KEY);
//if (instance != null)
//{
// return instance;
//}
Did it cause any issue ? Or I hope to recover them, as it will be more
easier to set other implemtations for other containers. The commons-discovery
package might not work correctly in OSGI environment. as they will try to
search META-INF/services folder, and this way sometimes might not work
correctly in OSGi environment.
thanks.
> Make a way to get the FacesConfig from a provider
> -------------------------------------------------
>
> Key: MYFACES-2945
> URL: https://issues.apache.org/jira/browse/MYFACES-2945
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General
> Affects Versions: 2.0.2
> Reporter: Ivan
>
> Currently, MyFaces startup listener will parse the all the faces
> configuration files and sort them on each startup time, and it will be better
> to do it once in the deployment time, and get those data structure instances
> from a provider. One possible way is to make those FacesConfig class
> serializable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
