[
https://issues.apache.org/jira/browse/MYFACES-2976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933393#action_12933393
]
Jakob Korherr commented on MYFACES-2976:
----------------------------------------
The patch looks very good. Thanks!
Two comments: I'd prefer "bundle" as module name over
"org.apache.myfaces.bundle" and also you don't need to include myfaces-impl-ee6
as dependency, because it already ships with myfaces-impl.
Besides that, I am in favour of committing this patch.
If there are no objections, I will commit (a slightly modified version of) this
patch soon!
> Support hiding myfaces impl classes in osgi, and provide a single osgi bundle
> for api + impl
> --------------------------------------------------------------------------------------------
>
> Key: MYFACES-2976
> URL: https://issues.apache.org/jira/browse/MYFACES-2976
> Project: MyFaces Core
> Issue Type: Improvement
> Components: Extension Feature
> Affects Versions: 2.0.3-SNAPSHOT
> Reporter: David Jencks
> Attachments: MYFACES-2976.diff
>
>
> The current osgi solution of using require-bundle between the api and impl
> jars is generally thought of as osgi worst-practice and just doesn't work
> with snapshot versions (presumably a bug in the bundle plugin).
> Also this does not easily support hiding the impl classes.
> Geronimo would like to use a single bundle containing both api and impl and
> hide the impl classes as much as possible. This requires some slight
> modifications to the FactoryFinder so that impl classes can be loaded from
> the same classloader as FactoryFinder if they are not visible to the context
> class loader.
> I think myfaces would be the best place for this combined bundle but geronimo
> can build it if necessary. The FactoryFinder classloader changes are
> therefore more important.
> I've suggested a module name which maps to the bundle symbolic name well, as
> this seems to be the preferred maven/osgi strategy at apache.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
