[ 
https://issues.apache.org/jira/browse/MYFACES-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934730#action_12934730
 ] 

Leonardo Uribe commented on MYFACES-2945:
-----------------------------------------

In MYFACES-2945-3.patch there is a proposal for the alternative 1. In few 
words, the idea is create a new abstract class called FacesConfigData and 
change FacesConfigurationProvider with this interface:

public abstract class FacesConfigurationProvider
{
   
    public abstract FacesConfigData getFacesConfigData(ExternalContext ectx);
    
}

After some attempts, the structure of the solution is not too different from 
the previous patch, because after all in DefaultFacesConfigurationProvider it 
is necessary to put all previous code plus ordering and feeding of FacesConfig 
files.

It requires some cleanup, remove some duplicate code on FacesConfigurator, and 
do some test but it looks good.

It could be good to know what do you think guys about this solution. If no 
objections I'll commit an updated of this solution soon.

> Make a way to get the FacesConfig from a provider
> -------------------------------------------------
>
>                 Key: MYFACES-2945
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2945
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 2.0.2
>            Reporter: Ivan
>            Assignee: Leonardo Uribe
>         Attachments: MYFACES-2945-2.patch, MYFACES-2945-3.patch
>
>
> Currently, MyFaces startup listener will parse the all the faces 
> configuration files and sort them on each startup time, and it will be better 
> to do it once in the deployment time, and get those data structure instances 
> from a provider. One possible way is to make those FacesConfig class 
> serializable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to