Defltaer/inflater from StateManagerImpl holds onto memory
---------------------------------------------------------

                 Key: TRINIDAD-1989
                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1989
             Project: MyFaces Trinidad
          Issue Type: Bug
          Components: Archetype
    Affects Versions:  1.2.12-core
            Reporter: Stevan Malesevic


StateManagerImpl correctly uses a instance of Deflater/Infalter from session 
scope for view state compression to avoid recreating these objects since they 
have finalizers which hurt jvm. Howevere, when returning inflater/deflater to 
session scope method reset will just reset position for the internal buffer but 
will not clean buffer. This has impact on preformance since we can pin large 
buffers for the duration of the session. To avoid this issue we can declare
private static final byte[] empty = new byte[0];

and call   decompressor.setInput(empty); and compressor.setInput(empty);


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to