-1

sorry Matze, but I need to veto because of:

            <dependencies>
              <dependency>
                <groupId>org.apache.myfaces.buildtools</groupId>
                <artifactId>checkstyle-rules</artifactId>
                <version>2-SNAPSHOT</version>
              </dependency>


We need to release the checkstyle rules first to be really clean.
It's sad that the maven-release plugin doesn't seem to check that SNAPSHOT 
plugin dependency :( I should trigger a discussion for that over on the maven 
list. 

The changed the checkstyle-rules is needed for the newer checkstyle-plugin. We 
used a almost 5 years old, and noone did update because of the rules now look 
slightly different. If fixed those rules and trunk is using them for a few 
months now already. So I think we should be save in rolling a release for 
checkstyle-rules-2 and then re-roll the myfaces-parent-10 release.

The old checkstyle-plugin has lots of known issues but the main problem is that 
it doesn't work with maven3...


txs and LieGrue,
strub



--- On Sat, 1/15/11, Matthias Wessendorf <[email protected]> wrote:

> From: Matthias Wessendorf <[email protected]>
> Subject: [VOTE] Apache MyFaces POM-10
> To: "MyFaces Development" <[email protected]>
> Date: Saturday, January 15, 2011, 12:29 PM
> Hi,
> 
> I've created a MyFaces-10 pom release candidate, with the
> following artifacts
> up for a vote:
> 
> SVN source tag (r1059311):
> https://svn.apache.org/repos/asf/myfaces/myfaces-master-pom/tags/myfaces-10/
> 
> Maven staging repo:
> https://repository.apache.org/content/repositories/orgapachemyfaces-033/
> 
> [ ] +1  approve
> [ ] +0  no opinion
> [ ] -1  disapprove (and reason why)
> 
> Thanks,
> Matthias
> 
> 
> 
> -- 
> Matthias Wessendorf
> 
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> twitter: http://twitter.com/mwessendorf
> 



Reply via email to