[
https://issues.apache.org/jira/browse/TRINIDAD-1767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983533#action_12983533
]
Jeanne Waldman edited comment on TRINIDAD-1767 at 1/18/11 11:30 PM:
--------------------------------------------------------------------
Sorry. We decided not to throw an exception since that is too harsh. Instead it
is best to add a warning, and maybe do a no-op. This is nicer than throwing an
exception. And our code assumes the skin does not change. Wacky things might
happen if they change a skin with the same id.
I have to investigate if anyone is relying on being able to add a skin over
again. So for now I am going to add a warning, then later do the no-op if that
won't break anyone.
was (Author: [email protected]):
Sorry. We decided not to throw an exception since that is too harsh.
Instead it is best to add a warning, and do a no-op. This is nicer than throwing
an exception. And our code assumes the skin does not change. Wacky things might
happen if they change a skin with the same id.
> Warn and no-op on SkinFactory.addSkin for duplicate skins.
> ----------------------------------------------------------
>
> Key: TRINIDAD-1767
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1767
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Components: Skinning
> Affects Versions: 1.2.13-core
> Reporter: Jeanne Waldman
> Attachments: 1767_1.2.x.patch, 1767_2.0.x.patch
>
>
> hrow an IllegalStateException from Trinidad's SkinFactory.addSkin() method
> if a skin id that already exists is added again. This will not change the
> method signature since IllegalStateException is an unchecked exception.
> This will keep a duplicate skin from overriding an existing one.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
