[
https://issues.apache.org/jira/browse/TRINIDAD-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986816#action_12986816
]
Pavitra Subramaniam commented on TRINIDAD-1996:
-----------------------------------------------
Thanks Michael. Your patch looks fine to me and also fixes a different issue. I
made some minor edits and uploaded a new patch - removed unused imports in the
file.
> FacesContextFactoryImpl's FacesContext (CacheRenderKit) needs to extend
> FacesContextWrapper not FacesContext
> ------------------------------------------------------------------------------------------------------------
>
> Key: TRINIDAD-1996
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1996
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 2.0.0-alpha-2
> Reporter: Michael Freedman
> Attachments: FacesContextFactoryImpl.patch
>
>
> Currently Trinidad's FacesContextFactoryImpl creates a FacesContext of type
> CacheRenderKit (declared in same file). CacheRenderKit is declared as a
> class that extends FacesContext. Instead it should extend
> FacesContextWrapper. By not using the wrapper Trinidad breaks other
> instances in the hierarchy (lower than it) as it misses the wrapper
> delegation model.
> Note: When you make this change. also remove the now obsolete methods that
> merely delegate.
> Testcase: Portlet Bridge TCK tests don't run unless this code is changed to
> extend the Wrapper.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
