[
https://issues.apache.org/jira/browse/MYFACES-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999067#comment-12999067
]
Leonardo Uribe commented on MYFACES-2995:
-----------------------------------------
DJ >> This looks ok to me although I don't like the amount of reflection that
much. A few comments:
Well, it is unavoidable.
DJ >> I don't see why FactoryFinderProvider is an abstract class rather than an
interface.
Good point. Yes, it could be an interface instead an abstract class, because it
is not expected this one could change in the future. I'll do the necessary
changes.
DJ >> why not have FactoryFinderProviderFactory just set an object field in the
api class directly?
It is not possible to do that because it introduces a circular dependency
between myfaces-api and myfaces-impl.
DJ >> I think I would make the tccl and optional replacement strategies more
similar by putting the tccl based code in a FactoryFinderProvider like object
set into _FactoryFinderProviderFactory by default.
Yes, it could be but I think it is better to let the code as is in the patch,
because it is easy to compare the javadoc against the code, and it is clear if
no FactoryFinderProvider implementation is provided, just do the default
algorithm. Other reason to take into account is do not use reflection if it is
not necessary.
DJ >> I haven't tried this with geronimo yet but I think it will work.
So can we close this issue as fixed? (after commit the code with some changed)
> Make method of determinine app context in FactoryFinder pluggable
> -----------------------------------------------------------------
>
> Key: MYFACES-2995
> URL: https://issues.apache.org/jira/browse/MYFACES-2995
> Project: MyFaces Core
> Issue Type: Improvement
> Components: SPI
> Affects Versions: 2.0.3-SNAPSHOT
> Reporter: David Jencks
> Attachments: MYFACES-2995-FactoryFinderProvider-1.patch,
> MYFACES-2995.patch
>
>
> As discussed on dev list.... geronimo would like to explicitly mark component
> boundaries rather than relying on the TCCL changing.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
