[
https://issues.apache.org/jira/browse/TRINIDAD-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000986#comment-13000986
]
Xiaoming Shi edited comment on TRINIDAD-2046 at 3/1/11 6:18 PM:
----------------------------------------------------------------
Hi Scott,
The buffer size should increase as the size of content increases, Still a
MAXIMUM_SIZE needed. We don't want it to create too large a buffer.
BTW, we have done unit test, and find that,
to copy 1MB data,
it takes 7282622 nano seconds with a buffer size 4096
while it takes 11470883 nano seconds with a buffer size 1024
was (Author: nancyesmis):
Hi Scott,
The buffer size should increase as the size of content increases, Still a
MAXIMUM_SIZE needed. We don't want it to create too large a buffer.
> Copying data from inputStream to OuputStream needs appropriate buffer size
> --------------------------------------------------------------------------
>
> Key: TRINIDAD-2046
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2046
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Components: Components
> Affects Versions: 1.2.14-core , 2.0.0-beta-2
> Reporter: Xiaoming Shi
> Labels: performance
>
> In the files
> ./trinidad-1.2.14/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/image/cache/FileSystemImageCache.java
> line:955
> ./trinidad-1.2.14/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/image/painter/ImageUtils.java
> line:303
> The buffer size is fixed as 1024 bytes. With the size of the data varies, the
> performance can be damaged a lot.
> We need an appropriate buffer size which depends on the size of the data to
> be copied.
> This is the same as the Appache Bug
> (https://issues.apache.org/bugzilla/show_bug.cgi?id=32546)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
