[
https://issues.apache.org/jira/browse/TRINIDAD-2054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004816#comment-13004816
]
Kentaro Kinebuchi commented on TRINIDAD-2054:
---------------------------------------------
Good point about the security risk. I updated the patch so that only exceptions
from the bean method are included.
Yes, there will be two messages. One will be the message from the exception
thrown by the bean method and the other will be the current generic error
message indicating that the download failed. The rationale for this patch is
that currently there is no way for the user to know why the download failed
since any exception thrown by the developer from within the bean method is not
displayed to the user. With this patch we are giving the developer at least the
ability to display a custom error message to the user.
MessageFactory.getMessage() calls getLocalizedMessage() so the message should
be localized.
> Messages from exceptions in tr:fileDownloadActionListener are not displayed
> ---------------------------------------------------------------------------
>
> Key: TRINIDAD-2054
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2054
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Components
> Affects Versions: 2.0.0-beta-2
> Environment: x86
> Reporter: Kentaro Kinebuchi
> Priority: Minor
> Attachments: JIRA2054.patch
>
>
> When the bean method referenced by tr:fileDownloadActionListener throws an
> exception, what is displayed to the user is always a generic message "The
> file was not downloaded or was not downloaded correctly.". The exception
> message itself is not displayed which makes it very hard for the user to know
> what actually went wrong.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
