[ 
https://issues.apache.org/jira/browse/MYFACES-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034906#comment-13034906
 ] 

Jakob Korherr commented on MYFACES-3151:
----------------------------------------

I actually was thinking of introducing a config class that provides all config 
options in a typesafe way (kinda like RuntimeConfig does on shared) some time 
ago. This would also be possible in shared and impl, but in api it is 
proplematic, since the jsf-spec dictates the classes of api. Thus you would 
need to have a package private config cache class in every package in api which 
uses some kind of config parameter.

+1 on implementing such a feature on shared and using it on impl. But I guess 
for api we can't do much.

> [perf] minimize ExternalContext.getInitPaparameter invocations
> --------------------------------------------------------------
>
>                 Key: MYFACES-3151
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3151
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 2.1.0-SNAPSHOT
>         Environment: myfaces core trunk
>            Reporter: Martin Kočí
>            Assignee: Martin Kočí
>            Priority: Minor
>
> init-param from webapp context cannot change - it is sufficient read it once 
> in constructor (ApplicationImpl for example)
> New problem (new in 2.1) is "great" 
> javax.faces.HONOR_CURRENT_COMPONENT_ATTRIBUTES param for pushComponentToEL 
> and popComponentFromEL - at least we can cache it in component (because push 
> and pop are called more then ones during one lifecycle) and maybe cache it's 
> value also in 
> org.apache.myfaces.context.servlet.ServletExternalContextImplBase.getInitParameter(String)
> I have about ~ 90 000 invocations of getInitPaparameter in my test case in 
> one request/response and that is not cheap.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to