[ 
https://issues.apache.org/jira/browse/MYFACES-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061388#comment-13061388
 ] 

Martin Kočí commented on MYFACES-3202:
--------------------------------------

> Provide TagAttribute instance ...
Because Method/ValueExpression are part of state saving, providing whole 
TagAttribute instance is not suitable, because it needs to be saved/restored.

Currently ValueExpression saves toString representation of TagAttributeImpl:

this.location + " " + this.qName + "=\"" + this.value + "\"";

We can save only 
1) location (as LocationValueExpression does already)
2) qName

saving 'this.value' is not necessary, because it is saved as part of wrapped 
ValueExpression

> Improve EL Exceptions wrapping
> ------------------------------
>
>                 Key: MYFACES-3202
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3202
>             Project: MyFaces Core
>          Issue Type: Sub-task
>          Components: General
>            Reporter: Martin Kočí
>            Priority: Minor
>
> From MYFACES-3053 "user should see not just a cryptic stack trace, but the EL 
> expression that was being evaluated  including the part of the EL expression 
> that triggered the problem"
> Myfaces utilize TagValueExpression and TagValueExpressionUEL as 
> TagAtrribute-aware wrappers around EL ValueExpression. But this "context" is  
> only .toString()  of TagAttribute and that prohibits user-frendly formatting 
> of messages.
> Provide TagAttribute instance, create TagAttributeAwareExceptionWrapper that 
> will hold this instance. Clients (mainly ErrorPage) can read attributes of 
> TagAttribute and format it as necessary, for example "EL expression that 
> triggered the problem: " + wrapper.getTagAttribute().getValue()

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to