[
https://issues.apache.org/jira/browse/MYFACES-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061905#comment-13061905
]
Jakob Korherr commented on MYFACES-3211:
----------------------------------------
attached patch.
The idea of this patch is the introduction of the myfaces-spi module containing
org.apache.myfaces.spi classes (no implementations) and the necessary data
objects (from org.apache.myfaces.config.element). This module will then be used
by myfaces-impl and myfaces-impl-ee6, making shaded-impl obsolete.
NOTE that the patch contains a lot of changes including many class relocations
and thus it may not work as expected. If there are problems with it, I can
create a branch of 2.1.x and apply my local changes there for clearance!
If there are no objections, I will commit this patch soon!
> Get rid of shaded-impl module
> -----------------------------
>
> Key: MYFACES-3211
> URL: https://issues.apache.org/jira/browse/MYFACES-3211
> Project: MyFaces Core
> Issue Type: Task
> Affects Versions: 2.1.0, 2.1.1
> Reporter: Jakob Korherr
> Assignee: Jakob Korherr
> Attachments: MYFACES-3211-proposal.patch
>
>
> In 2.1.0 the shaded-impl module was introduced in order to solve a cyclic
> dependency problem (access classes of myfaces-impl in myfaces-impl-ee6).
> However, this introduces unnecessary redundancy and complexity to our build
> process and is subject to a lot of problems (currently shaded-impl is
> myfaces-impl:2.0.5, but it is used as if it was myfaces-impl:2.1.1, which
> could lead to inconsistencies and other problems).
> Some time ago we briefly discussed a solution to this problem: the
> introduction of a myfaces-spi module. This module contains all classes of the
> org.apache.myfaces.spi package (not *.spi.impl) and the necessary data
> objects. It is independent of impl and impl-ee6 and thus can be used by them!
> I will attach a patch for this one shortly!
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
