hi, thx for reviewing the changes. for sure we can discuss when we are going to do such changes. however, if ext-script is the only reason against it, we can do it right now imo. there is no problem with shipping a small update of ext-script and the user base is currently small enough to communicate this change easily.
regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2011/7/8 Leonardo Uribe <[email protected]> > Hi > > In principle I agree with this change, but after a quick patch review > I saw some package relocation for some classes (from > org.apache.myfaces.config.element to org.apache.myfaces.spi.data). > Those changes will break extensions scripting code. Such changes > should be done between major versions (2.2.0). Please do not change > the package names. > > regards, > > Leonardo Uribe > > 2011/7/8 Gerhard Petracek <[email protected]>: > > +1 > > regards, > > gerhard > > > > http://www.irian.at > > > > Your JSF powerhouse - > > JSF Consulting, Development and > > Courses in English and German > > > > Professional Support for Apache MyFaces > > > > > > > > 2011/7/8 Jakob Korherr <[email protected]> > >> > >> Hi guys, > >> > >> We currently use the shaded-impl module in core 2.1.x to solve a > >> cyclic dependency problem. However, this introduces redundancy and > >> complexity and may lead to some strange issues. This can be solved by > >> the introduction of a myfaces-spi module (which is then packed > >> together with myfaces-impl, just like myfaces-impl-ee6 is). > >> > >> Please see MYFACES-3211 [1] for a detailed description of the solution > >> and a patch for it. > >> > >> If there are no objections, I will commit this patch soon! > >> > >> Regards, > >> Jakob > >> > >> [1] https://issues.apache.org/jira/browse/MYFACES-3211 > >> > >> -- > >> Jakob Korherr > >> > >> blog: http://www.jakobk.com > >> twitter: http://twitter.com/jakobkorherr > >> work: http://www.irian.at > > > > >
