[
https://issues.apache.org/jira/browse/MYFACES-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13072360#comment-13072360
]
Martin Kočí commented on MYFACES-3250:
--------------------------------------
Yes, the purpose is clear. I didn't mean to remove @PreDestroy functionality,
only find a way how to not register this HttpSessionAttributeListener if no
managed beans are used. This can be considered as part of [1] and will improve
performance when running modern stack like CDI.
[1] http://www.mail-archive.com/[email protected]/msg49177.html
> [perf] review StartupServletContextListener if HttpSessionAttributeListener
> is required
> ---------------------------------------------------------------------------------------
>
> Key: MYFACES-3250
> URL: https://issues.apache.org/jira/browse/MYFACES-3250
> Project: MyFaces Core
> Issue Type: Improvement
> Environment: myfaces trunk, tomcat 6.0.26
> Reporter: Martin Kočí
> Priority: Minor
>
> When running stress test this is one of the most BLOCKED thread (blocked on
> some ArrayList monitor in tomcat internals):
> org.apache.catalina.core.ContainerBase.fireContainerEvent(String, Object)
> org.apache.catalina.session.StandardSession.fireContainerEvent(Context,
> String, Object)
> org.apache.catalina.session.StandardSession.setAttribute(String,
> Object, boolean)
> org.apache.catalina.session.StandardSession.setAttribute(String,
> Object)
>
> org.apache.catalina.session.StandardSessionFacade.setAttribute(String,
> Object)
>
> org.apache.myfaces.context.servlet.SessionMap.setAttribute(String, Object)
>
> org.apache.myfaces.util.AbstractThreadSafeAttributeMap.put(String, Object)
>
> org.apache.myfaces.util.AbstractThreadSafeAttributeMap.put(Object, Object)
> This happens when someone puts a attribute into httpSession:
> org.apache.myfaces.util.AbstractThreadSafeAttributeMap.put(Object, Object)
>
> org.apache.myfaces.renderkit.ServerSideStateCacheImpl.nextViewSequence(FacesContext)
>
> org.apache.myfaces.view.facelets.FaceletViewDeclarationLanguage.getResponseEncoding(FacesContext,
> String)
>
> org.apache.myfaces.renderkit.ServerSideStateCacheImpl.saveSerializedViewInServletSession(FacesContext,
>
> then Servlet container delivers event HttpSessionBindingEvent.
> in myfaces HttpSessionAttributeListener in implemented by
> oam.StartupServletContextListener and handles some stuff for managed beans.
> Review if this is needed - ideally remove it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
