thats true! So, I'd like to change my VOTE to a
+1 release bits look good, and we canreally change the checkstyle rules later. LieGrue, strub >________________________________ > From: Gerhard Petracek <[email protected]> >To: MyFaces Development <[email protected]> >Sent: Thursday, December 15, 2011 11:14 AM >Subject: Re: [VOTE] release for myfaces master pom v 12 > > >hi, > > >if we need it for releasing an important bugfix release, i would continue - >otherwise i agree with mark. > > >regards, >gerhard > >http://www.irian.at > >Your JSF/JavaEE powerhouse - >JavaEE Consulting, Development and >Courses in English and German > >Professional Support for Apache MyFaces > > > > >2011/12/15 Mark Struberg <[email protected]> > >-0.5 >> >> >> >>The checkstyle-rules-default and checkstyle-rules-strict now doesn't match >>anymore. >> >>ParameterNumber = 20 in default and 10 in strict >> >>Instead we should imo let ParamNumber=10 for both and enable the block >>exclude tokens by adding the following [1] to all our checkstyle rules >> >><module name="SuppressionCommentFilter"/> >> >> >>In our code we can then just simply write >> >> >>> // CHECKSTYLE:OFF >>> doSomeDirtyStuff(); >> >>> // CHECKSTYLE:ON >> >> >> >>LieGrue, >>strub >> >> >>[1] http://checkstyle.sourceforge.net/config.html >> >> >> >>----- Original Message ----- >>> From: Leonardo Uribe <[email protected]> >>> To: MyFaces Development <[email protected]> >>> Cc: >>> Sent: Wednesday, December 14, 2011 10:30 PM >>> Subject: [VOTE] release for myfaces master pom v 12 >>> >>> Hi, >>> >>> I was running the needed tasks to get the version 12 release of Apache >>> MyFaces Master POM. >>> >>> This release include a change to enable checkstyle plugin over myfaces core >>> and >>> an update of the developer/contributor list for myfaces site. >>> >>> Please note that this vote concerns all of the following parts: >>> >>> 1. Maven artifact group "org.apache.myfaces.myfaces" v 12 [1] >>> 2. Maven artifact group "org.apache.myfaces.buildtools" >>> checkstyle-rules v 4 >>> >>> The artifacts are deployed to a nexus staging repository [1]. >>> >>> Please take a look at the version 12 pom and vote! >>> >>> Please note: This vote is "majority approval" with a minimum of three >>> +1 votes (see [3]). >>> >>> ------------------------------------------------ >>> [ ] +1 for community members who have reviewed the bits >>> [ ] +0 >>> [ ] -1 for fatal flaws that should cause these bits not to be released, >>> and why.............. >>> ------------------------------------------------ >>> >>> Thanks, >>> Leonardo Uribe >>> >>> [1] https://repository.apache.org/content/repositories/orgapachemyfaces-338 >>> >>> https://repository.apache.org/content/groups/staging/org/apache/myfaces/myfaces/12/ >>> >>> https://repository.apache.org/content/groups/staging/org/apache/myfaces/buildtools/checkstyle-rules/4/ >>> >> >> > > >
