[ 
https://issues.apache.org/jira/browse/MYFACES-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leonardo Uribe updated MYFACES-3437:
------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.1.6
                   2.0.12
           Status: Resolved  (was: Patch Available)

I checked all patches and applied most of them. I did some small adjustments on 
DefaultFacelet.patch. There are some places where some methods should be 
private instead public.

I think NavigationHandler.patch is not a good idea, because it changes one 
method signature that is part of "myfaces impl api", and the code affected is 
only executed once, so the improvement is microscopic compared with the trouble.

I didn't applied HtmlAjaxBehaviorRenderer.patch, because I had planned to 
rewrite that renderer in a way that does not use so many StringBuilder 
instances, so I'll keep in mind those changes to include them later.

Thanks to Martin Koci for provide these patches.
                
> [PERF] Use index-based loop where possible
> ------------------------------------------
>
>                 Key: MYFACES-3437
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3437
>             Project: MyFaces Core
>          Issue Type: Sub-task
>          Components: JSR-314
>    Affects Versions: 2.0.12-SNAPSHOT, 2.1.6-SNAPSHOT
>         Environment: myfaces core trunk
>            Reporter: Martin Kočí
>            Assignee: Martin Kočí
>            Priority: Trivial
>             Fix For: 2.0.12, 2.1.6
>
>         Attachments: ApplicationImpl.patch, DefaultFacelet.patch, 
> DefaultFaceletsStateManagementStrategy.patch, 
> FaceletCompositionContextImpl.patch, FacesConfigurator.patch, 
> HtmlAjaxBehaviorRenderer.patch, HtmlBodyRendererBase.patch, 
> HtmlGridRendererBase.patch, HtmlHeadRenderer.patch, 
> HtmlLinkRendererBase.patch, HtmlRendererUtils.patch, 
> HtmlTableRendererBase.patch, NavigationHandler.patch, UIRepeat.patch
>
>
> use index based loop where possible, see class java.util.RandomAccess for 
> details

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to