Hello, Can someone review and commit the patch?
Thanks Anand On 1/13/2012 12:33 PM, Anand V Nath (Commented) (JIRA) wrote:
[ https://issues.apache.org/jira/browse/TRINIDAD-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185462#comment-13185462 ] Anand V Nath commented on TRINIDAD-2196: ---------------------------------------- jira-2196.patch if for trunk, jira-2196-1.2.12.6.2.patch is for 1.2.12.6.2 branchMenuUtils creates a large number of ThreadLocals ------------------------------------------------ Key: TRINIDAD-2196 URL: https://issues.apache.org/jira/browse/TRINIDAD-2196 Project: MyFaces Trinidad Issue Type: Bug Components: Components Affects Versions: 1.2.12-core Reporter: Stevan Malesevic Attachments: jira-2196-1.2.12.6.2.patch, jira-2196.patch org.apache.myfaces.trinidad.menu.MenuUtils::loadBundle creates a lot of ThreadLocals object which then have a high CPU ipmact at the end of request when they need to be removed It is not clear: 1) Why ThreadLocal is needed at the first place here 2) Even if it is needed why create it before checking map for existence of bundle-- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
