Hi Scott! While checking the release I also scanned the other stuff and the rest looks good.
sorry for the inconvenience... LieGrue, strub ----- Original Message ----- > From: Scott O'Bryan <[email protected]> > To: MyFaces Development <[email protected]> > Cc: > Sent: Friday, February 24, 2012 3:49 PM > Subject: Re: [VOTE] Release of Trinidad 2.0.1 > > I stand corrected, it IS in there. :D We've had those repos in there > forever. Anyway, thanks Mark. > > So I've checked in the changes you requested to the latest tag and set > up the rat audit tool to run as part of the standard build so we don't > hit this issue again. Can you do me a favor and check the tag to make > sure it looks good and then I'll promote it to the repository and start > over the vote. > > Thanks, > Scott > > On Fri 24 Feb 2012 06:56:50 AM MST, Scott O'Bryan wrote: >> I'm not sure I agree with this. In the case of java.net, removing the >> invalid repo is a fair assessment, but I'm unaware of any rules in >> maven-central that says build artifacts cannot be pulled in from other >> repositories. Am I missing something here? >> >> That said, I didn't have time yesterday to investigate the problem. >> It might just be a simple Geronimo dep issue. I have a few mins to >> look at this. Hopefully it's not a difficult problem. >> >> Sent from my iPhone >> >> On Feb 24, 2012, at 6:33 AM, Mark Struberg<[email protected]> wrote: >> >>> Hi Scott! >>> >>>> As for the repositories, I removed them and now seem to be getting > an >>>> error during testing. >>> >>> >>> Well, doesn't that mean that the source repository doesn't > properly build? >>> >>> Also, such artifacts should not get propagated to maven.central as per > it's policies. >>> >>> >>> If you need help with the repo stuff then please ping me on IRC and > I'll help. >>> >>> >>> LieGrue, >>> strub >>> >>> >>> >>> ----- Original Message ----- >>>> From: Scott O'Bryan<[email protected]> >>>> To: MyFaces Development<[email protected]> >>>> Cc: >>>> Sent: Friday, February 24, 2012 2:07 PM >>>> Subject: Re: [VOTE] Release of Trinidad 2.0.1 >>>> >>>> Okay Marc, I fixed rat and the few license headers we have. It > will >>>> now also run automagically as part of the Trinidad build so we can >>>> catch these sooner. >>>> >>>> As for the repositories, I removed them and now seem to be getting > an >>>> error during testing. I guess my question is this, since we > don't >>>> distribute any jboss code with the product, is the repository issue >>>> still a blocker or can it be handled as a bug next release? >>>> >>>> Scott >>>> >>>> Sent from my iPhone >>>> >>>> On Feb 23, 2012, at 7:07 AM, Mark > Struberg<[email protected]> wrote: >>>> >>>>> Hi! >>>>> >>>>> I'm really sorry, but I fear I have to cast a >>>>> >>>>> -1 :( >>>>> >>>>> >>>>> >>>>> A few smallish but imo important things which I found during > the review: >>>>> >>>>> 1.) >>>>> >>>>> <repositories> >>>>> <!-- needed for Bean Validation API --> >>>>> <repository> >>>>> <id>jboss</id> >>>>> <name>jboss nexus</name> >>>>> >>>> > <url>http://repository.jboss.org/nexus/content/groups/public-jboss/</url> >>>>> </repository> >>>>> >>>>> <!-- Needed for Mojarra --> >>>>> <repository> >>>>> <id>maven2-repository.dev.java.net</id> >>>>> <name>Java.net Repository for Maven</name> >>>>> > <url>http://download.java.net/maven/2/</url> >>>>> </repository> >>>>> </repositories> >>>>> >>>>> is this really needed? >>>>> please the geronimo-spec jar for JSR-303 and Apache BVal > instead. >>>>> >>>>> the java.net repo is btw dead already... All mojarra artifacts > are >>>> available on maven.central >>>>> >>>>> Artifacts with a dead repo in it should definitely not get > propagated to >>>> maven.central! >>>>> >>>>> >>>>> 2.) please run mvn apache-rat:check >>>>> >>>>> The following files misses an ALv2 header: >>>>> >>>>> >>>>> > trinidad-build/src/main/resources/META-INF/maven-faces-plugin/Global.xml >>>>> > trinidad-api/src/main/conf/META-INF/myfaces-core-2_0-metadata.xml >>>>> >>>>> >>>> > trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/testScripts/ >>>>> contains a lot of stuff, but this should get excluded as they > are only test >>>> resources. >>>>> >>>>> Please add the apache-rat plugin to the build and fix the > missing headers >>>> or tweak the excludes until the build runs fine. >>>>> >>>>> LieGrue, >>>>> strub >>>>> >>>>> >>>>> >>>>> ----- Original Message ----- >>>>>> From: Andy Schwartz<[email protected]> >>>>>> To: MyFaces Development<[email protected]> >>>>>> Cc: >>>>>> Sent: Thursday, February 23, 2012 1:31 PM >>>>>> Subject: Re: [VOTE] Release of Trinidad 2.0.1 >>>>>> >>>>>> +1 >>>>>> >>>>>> Andy >>>>>> >>>>>> On Feb 22, 2012, at 12:18 AM, Scott O'Bryan >>>> <[email protected]> >>>>>> wrote: >>>>>> >>>>>>> Hi Everyone, >>>>>>> >>>>>>> I was running the tasks needed to get the Trinidad > 2.0.1 release >>>> out and >>>>>> now I need a vote as to whether everything looks good or > not. I have >>>> committed >>>>>> most of the most recent submitted patches and things look > to be fairly >>>> stable. >>>>>> There are a few patches outstanding, but I wanted to put > those into >>>> trunk so >>>>>> that they can get some more testing. >>>>>>> >>>>>>> This is a very big release with many bug fixes and > quite a few >>>> fixes to >>>>>> support the MyFaces checkstyle audits. You will notice the > absence of >>>> the >>>>>> "component showcase" example module. It was > decided to >>>> remove this >>>>>> module because it contains code brought in by Maven which > is NOT under >>>> the >>>>>> Apache license. The component showcase *IS* available by > building the >>>> source >>>>>> manually. >>>>>>> >>>>>>> At this time, I would like to ask for a vote on this > release. All >>>> of the >>>>>> following should be ready for review: >>>>>>> >>>>>>> * The generated repository and assembly artifacts [1] >>>>>>> * The generated source archive [2] >>>>>>> * The updated svn repository [3] >>>>>>> >>>>>>> Please review the artifacts and vote according to the > following: >>>>>>> >>>>>>> ------------------------------------------------ >>>>>>> [ ] +1 for community members who have reviewed the bits >>>>>>> [ ] +0 >>>>>>> [ ] -1 for fatal flaws that should cause these bits not > to be >>>> released, >>>>>>> and why.............. >>>>>>> ------------------------------------------------ >>>>>>> >>>>>>> This vote will remain open for at least 72 hours. >>>>>>> >>>>>>> Thanks, >>>>>>> Scott O'Bryan >>>>>>> >>>>>>> [1] >>>>>> >>>> > https://repository.apache.org/content/repositories/orgapachemyfaces-005/ >>>>>>> [2] >>>>>> >>>> > https://repository.apache.org/content/repositories/orgapachemyfaces-005/org/apache/myfaces/trinidad/trinidad/2.0.1/trinidad-2.0.1-source-release.zip >>>>>>> [3] >>>> > https://svn.apache.org/repos/asf/myfaces/trinidad/tags/trinidad-2.0.1/ >>>>>>> >>>>>> >>>> >
