[ 
https://issues.apache.org/jira/browse/TRINIDAD-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220959#comment-13220959
 ] 

Max Starets commented on TRINIDAD-2218:
---------------------------------------

Hey Scott, thanks for reviewing the patch. 
Configurator.disableConfiguratorServices() did not work because we weren't 
releasing the RequestContext at the end.
When you say 'Trinidad filter', do you mean TrinidadFilterImpl? The issue is 
that RequestContext is not available there. If you mean filters invoked after 
Configurators, then it won't work either because we need to provide a window Id 
to configurators.
Lets discuss this offline
                
> Need an ability for the WindowManager implementation to be executed before 
> all Configurators and filters and to complete teh response
> -------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TRINIDAD-2218
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2218
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>    Affects Versions: 2.0.2-core
>            Reporter: Max Starets
>            Assignee: Scott O'Bryan
>         Attachments: trinidad-2218.patch
>
>
> Since WindowManager is expected to make the Window Map available to all 
> Configurators, we need a way to ensure that it is executed before all 
> Configurators and filters. Also, WindowManager needs to be able to complete a 
> response, so that it can send a script response to the client.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to