[ 
https://issues.apache.org/jira/browse/MYFACES-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397555#comment-13397555
 ] 

Leonardo Uribe commented on MYFACES-3562:
-----------------------------------------

By coincidence, I found one way to prevent create AttachedDeltaWrapper 
instances changing the array size. I remembered a similar trick in 
UIComponentBase. So, I have attached a patch with junit test cases, trying all 
possible combinations, and in the way I found one missing case with transient 
property and PartialStateHolder too. 

If no objections I'll commit the proposed patch soon.
                
> [perf] Optimize UIOutput.saveState(FacesContext)
> ------------------------------------------------
>
>                 Key: MYFACES-3562
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3562
>             Project: MyFaces Core
>          Issue Type: Improvement
>            Reporter: Martin Kočí
>            Priority: Trivial
>         Attachments: MYFACES-3562-2.patch, MYFACES-3562.patch
>
>
> 1) use converterSaved as delta change check
> 2)  remove nullDelta boolean
> 3) move  new _AttachedDeltaWrapper into if (attachedState != null) statement
> question: _AttachedDeltaWrapper used in this context provides Class of 
> Converter, but that info is not used in restoreState - can we remove usage of 
> that wrapper?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to