[ 
https://issues.apache.org/jira/browse/TRINIDAD-2216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480838#comment-13480838
 ] 

Robert Schoch edited comment on TRINIDAD-2216 at 10/21/12 1:43 PM:
-------------------------------------------------------------------

This is a code snipped from trinidad-2.0.1-api, class 
org.apache.myfaces.trinidad.render.CoreRenderer.java:

  ...
    /**
     * Returns true if the component should render an ID. Components
     * that deliver events should always return "true".
     */
    // TODO Is this a bottleneck?  If so, optimize!
    protected boolean shouldRenderId(
  ...

But I can not find any code that does this really what's in the comment.
Not even in the subclasses.

Patch proposal follows...

EDIT: Patch is now available, see Attachment TRINIDAD-2216-2259-2302.patch
                
      was (Author: robs888):
    This is a code snipped from trinidad-2.0.1-api, class 
org.apache.myfaces.trinidad.render.CoreRenderer.java:

  ...
    /**
     * Returns true if the component should render an ID. Components
     * that deliver events should always return "true".
     */
    // TODO Is this a bottleneck?  If so, optimize!
    protected boolean shouldRenderId(
  ...

But I can not find any code that does this really what's in the comment.
Not even in the subclasses.

Patch proposal follows...
                  
> The partialSubmit does not work with JSF 2 RI
> ---------------------------------------------
>
>                 Key: TRINIDAD-2216
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2216
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 2.0.0-core
>         Environment: Mojarra 2.1.6 (SNAPSHOT 20111206)
> Glassfish 3.1.1
> Trinidad 2.0.0
>            Reporter: Tomas Havelka
>         Attachments: TRINIDAD-2216-2259-2302.patch
>
>
> Trinidad's partialSubmit does not work because the source parameter passed in 
> the jsf.ajax.request call is null. See XMLRequest.js on the line 358. The 
> source is part of the payload but is not assigned to the source parameter 
> itself. It causes the RI implementation of jsf.ajax.request throws an error 
> because of this code in it:
> if (typeof source === 'undefined' || source === null) {
>   throw new Error("jsf.ajax.request: source not set");
> } 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to