[
https://issues.apache.org/jira/browse/MYFACES-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534222#comment-13534222
]
dennis hoersch commented on MYFACES-3659:
-----------------------------------------
Thanks for your reply.
> Set a "transient" just works for the server side, but on the client the
> resource is not unloaded, so it does not have any effect.
Do I understand it right: To 'unload' (or 'load' new) resources in ajax
requests the hint 'requestViewContext.setRenderTarget(target, true)' should be
set? And then, for example if the isRenderTarget(head) flag is set, the whole
head will be encoded in the partial response?
If so, one solution might be the 'transient' thing and to check during the ajax
request whether there is any difference in the list if component resources to
the one of the previous request and set the appropriate 'isRenderTarget()' flag.
Some components add resources on 'PostAddToViewEvent' or
'PreRenderViewAddResourceEvent'. So the checking might be directly before
creating the (ajax) response. The best place I found so far is in
UIViewRoot.encodeAll():
---
@Override
public void encodeAll(FacesContext context) throws IOException
{
checkComponentResourcesForReRendering(context, "head");
checkComponentResourcesForReRendering(context, "body");
checkComponentResourcesForReRendering(context, "form");
super.encodeAll(context);
}
private void checkComponentResourcesForReRendering(FacesContext context, String
target)
{
String attributeName = "_OLD_COMPONENT_RESOURCES_" + target;
List<UIComponent> resources = getComponentResources(context, target);
String newResourcesMarker = resourcesToString(resources);
if (context.getPartialViewContext().isAjaxRequest())
{
String oldResourcesMarker = (String) getAttributes().get(attributeName);
if (oldResourcesMarker != null &&
!newResourcesMarker.equals(oldResourcesMarker))
{
if (!ExternalContextUtils.isPortlet(context.getExternalContext()) &&
!context.getAttributes().containsKey(StateManager.IS_BUILDING_INITIAL_STATE) &&
MyfacesConfig.getCurrentInstance(context.getExternalContext()).isStrictJsf2RefreshTargetAjax())
{
//!(component.getParent() instanceof ComponentResourceContainer)
RequestViewContext requestViewContext =
RequestViewContext.getCurrentInstance(context);
requestViewContext.setRenderTarget(target, true);
}
}
}
getAttributes().put(attributeName, newResourcesMarker);
}
private String resourcesToString(List<UIComponent> resources)
{
StringBuilder sb = new StringBuilder();
for (UIComponent resource : resources)
{
sb.append(resource.getAttributes().get("library")).append(":").append(resource.getAttributes().get("name")).append(";");
}
return sb.toString();
}
---
Setting the flag in 'HtmlStylesheetRenderer' and 'HtmlScriptRenderer' could be
removed than.
> Conditional include of scripts and stylesheets
> -----------------------------------------------
>
> Key: MYFACES-3659
> URL: https://issues.apache.org/jira/browse/MYFACES-3659
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 2.1.6
> Environment: MyFaces 2.1.6, Tomahawk20 1.1.11
> Reporter: dennis hoersch
>
> I am inserting a script 'X.js' dependent on a condition (c:if). The default
> case is to include it. If I change the underlying value within an action so
> that the condition evaluates to false, the script is still included. Also
> after any other following action.
> Using F5 in Firefox the page is now rendered without the script.
> The script 'X.js' was added to the view root and is never 'forgot' or
> removed. It is the same if the script is included in a composite component.
> In that case I even observed that the order of the scripts changes and the
> script 'X.js' is included before other basic scripts like jQuery on which
> 'X.js' depends.
> ----
> <h:form id="form">
> <c:set var="sessionScope"
> value="#{facesContext.externalContext.sessionMap}" />
>
> <h:commandButton value="deactivate"
> rendered="#{empty sessionScope.__isActive_ or
> sessionScope.__isActive_}">
> <f:setPropertyActionListener target="#{sessionScope.__isActive_}"
> value="#{false}" />
> </h:commandButton>
> <h:commandButton value="activate"
> rendered="#{not empty sessionScope.__isActive_ and not
> sessionScope.__isActive_}">
> <f:setPropertyActionListener target="#{sessionScope.__isActive_}"
> value="#{true}" />
> </h:commandButton>
>
> <h:commandButton value="do nothing" />
>
> <h:outputScript library="js" name="jQuery.js" target="body" />
>
> <c:if test="#{empty sessionScope.__isActive_ or sessionScope.__isActive_}">
> BLA
> <h:outputScript library="js" name="X.js" target="body" />
> </c:if>
> </h:form>
> ----
> Am I doing something wrong? Is there another (or better) way to include
> scripts conditionally?
> (
> If I change 'HtmlOutputScriptHandler' to set the script transient, it works
> in the first glance, but I don't know the impact...
> @Override
> public void onComponentPopulated(FaceletContext ctx, UIComponent c,
> UIComponent parent) {
> super.onComponentPopulated(ctx, c, parent);
> c.setTransient(true);
> }
> )
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
