- signatures and checksums match
- source builds
- apache rat passes (after I removed
myfaces-core-module-2.1.12/DEPENDENCIES and excluded
ServletContainerInitializer)
+1
The following items in
Myfaces-core-2.1.12-src/src/myfaces-core-module-2.1.12/ still trigger
rat failures:
DEPENDENCIES
impl/src/main/resources/META-INF/services/javax.servlet.ServletContainerInitializer
I'm pretty sure this was also true the last time I voted.
We should either exclude these with comments stating why they can (or
must) be excluded in the pom or add licenses.
I am pretty sure both are candidates for exclusion.
Below are the linux commands I used to verify the release of the
myfaces-core-assembly-2.1.12-src files:
=============================================
# check checksums
find . -name '*.md5' -exec cat {} \; -printf ' %f\n' | sed
's|\.md5$||' | md5sum -c
find . -name '*.sha1' -exec cat {} \; -printf ' %f\n' | sed
's|\.sha1$||' | sha1sum -c
# check signatures
wget http://www.apache.org/dist/myfaces/KEYS
gpg --import KEYS
find . -name '*.asc' -exec gpg --verify {} \;
# verify tar.gz and zip sources are identical
mkdir src
cd src
tar xvf ../myfaces-core-assembly-2.1.12-src.tar.gz
mv myfaces-core-2.1.12-src/ myfaces-core-2.1.12-src-tar-gz
unzip ../myfaces-core-assembly-2.1.12-src.zip
# should be no output
diff -rq myfaces-core-2.1.12-src*
# should be "are identical" output
diff -srq myfaces-core-2.1.12-src*
# build source
cd myfaces-core-2.1.12-src/src
find \( -name '*.jar' -o -name '*.zip' \) -exec unzip -n {} \;
cd myfaces-core-module-2.1.12/
mvn install
mvn apache-rat:check
# To check for all errors, if more than one project is affected
# mvn apache-rat:check -Drat.numUnapprovedLicenses=9999
# To see details of rat failure
# mvn -e -X apache-rat:check
On Wed, May 29, 2013 at 7:48 PM, Hazem Saleh <[email protected]> wrote:
> +1
>
> Sent from my iPad
>
> On May 29, 2013, at 8:53 PM, Leonardo Uribe <[email protected]> wrote:
>
>> +1
>>
>> 2013/5/29 Leonardo Uribe <[email protected]>:
>>> Hi,
>>>
>>> I was running the needed tasks to get the 2.1.12 release of Apache
>>> MyFaces core out.
>>>
>>> The artifacts passed all TCK tests.
>>>
>>> Please note that this vote concerns all of the following parts:
>>> 1. Maven artifact group "org.apache.myfaces.shared" v4.1.10 [1]
>>> 2. Maven artifact group "org.apache.myfaces.core" v2.1.12 [1]
>>>
>>> The artifacts were deployed on nexus repo [1] and to my private
>>> Apache account [3] for binary and source packages.
>>>
>>> The release notes could be found at [4].
>>>
>>> Also the clirr test does not show binary incompatibilities with myfaces-api.
>>>
>>> Please take a look at the "2.1.12" artifacts and vote!
>>>
>>> Please note: This vote is "majority approval" with a minimum of three
>>> +1 votes (see [3]).
>>>
>>> ------------------------------------------------
>>> [ ] +1 for community members who have reviewed the bits
>>> [ ] +0
>>> [ ] -1 for fatal flaws that should cause these bits not to be released,
>>> and why..............
>>> ------------------------------------------------
>>>
>>> Thanks,
>>> Leonardo Uribe
>>>
>>> [1]
>>> https://repository.apache.org/content/repositories/orgapachemyfaces-029/org/apache/myfaces/
>>> [2] http://www.apache.org/foundation/voting.html#ReleaseVotes
>>> [3] http://people.apache.org/~lu4242/myfaces2112binsrc
>>> [4]
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&version=12324285
