[
https://issues.apache.org/jira/browse/MYFACES-3717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13758593#comment-13758593
]
Leonardo Uribe commented on MYFACES-3717:
-----------------------------------------
I have checked the patch and theorically the intention is correct (just add
"role" attributes as an universal attribute), but the patch has some bugs (add
role in some arrays, so it can be rendered at the right time, fix the logic for
h:message and h:messages, add the render logic in the right spots) and
checkstyle plugin don't allow tab characters in myfaces files (run a mvn
install helps to find these kind of issues). I fixed them, do a commit and
created a new patch, so you can see what was missing. In MyFaces code there is
already a junit test case for html attributes, so I just added role attribute
to check everything is in place. I think there is no additional work here to
do, so I'll close this one as fixed.
Thanks to Dora Rajappan for provide a patch and a test case for it.
> Implement "role" attribute in related components and renderers
> --------------------------------------------------------------
>
> Key: MYFACES-3717
> URL: https://issues.apache.org/jira/browse/MYFACES-3717
> Project: MyFaces Core
> Issue Type: Task
> Components: JSR-344
> Reporter: Leonardo Uribe
> Attachments: MYFACES-3717-rolepassthrough-2.patch,
> rolepassedthrough.patch, rolepassedthroughtest.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
