Anand V Nath created TRINIDAD-2433:
--------------------------------------
Summary: unnecessary use of FacesContext in SkinProvider API
Key: TRINIDAD-2433
URL: https://issues.apache.org/jira/browse/TRINIDAD-2433
Project: MyFaces Trinidad
Issue Type: Bug
Components: Skinning
Affects Versions: 2.1.0-core
Reporter: Anand V Nath
Priority: Minor
SkinProvider API uses FacesContext in its methods. All that is done inside the
API is to extract the ExternalContext. So it is sufficient to pass
ExternalContext to the API. Though this is a public API change, the
SkinProvider API is introduced recently and not widely used. This gives us a
chance to correct the API now.
Proposed change:
- public Collection<SkinMetadata> getSkinMetadata(FacesContext context)
+ public Collection<SkinMetadata> getSkinMetadata(ExternalContext context)
{
return Collections.emptyList();
}
- public abstract Skin getSkin(FacesContext context, SkinMetadata
skinMetadata);
+ public abstract Skin getSkin(ExternalContext context, SkinMetadata
skinMetadata);
and the related internal API changes.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
