[
https://issues.apache.org/jira/browse/TRINIDAD-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13838004#comment-13838004
]
Jeanne Waldman commented on TRINIDAD-2433:
------------------------------------------
Sending content:
C:\Trinidad\Trunk3\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\skin\provider\ExternalSkinProvider.java
Sending content:
C:\Trinidad\Trunk3\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\skin\SkinFactoryImpl.java
Sending content:
C:\Trinidad\Trunk3\trinidad-api\src\main\java\org\apache\myfaces\trinidad\skin\SkinMetadata.java
Sending content:
C:\Trinidad\Trunk3\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\skin\provider\TrinidadBaseSkinProvider.java
Sending content:
C:\Trinidad\Trunk3\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\skin\SkinUtils.java
Sending content:
C:\Trinidad\Trunk3\trinidad-api\src\main\java\org\apache\myfaces\trinidad\skin\SkinVersion.java
Sending content:
C:\Trinidad\Trunk3\trinidad-api\src\main\java\org\apache\myfaces\trinidad\skin\CustomMetadata.java
Sending content:
C:\Trinidad\Trunk3\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\skin\provider\TrinidadSkinProvider.java
Sending content:
C:\Trinidad\Trunk3\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\skin\pregen\SkinPregenerationService.java
Sending content:
C:\Trinidad\Trunk3\trinidad-api\src\main\java\org\apache\myfaces\trinidad\skin\SkinProvider.java
Sending content:
C:\Trinidad\Trunk3\trinidad-impl\src\test\java\org\apache\myfaces\trinidadinternal\renderkit\RenderKitTestCase.java
Sending content:
C:\Trinidad\Trunk3\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\skin\provider\SkinProviderRegistry.java
Sending content:
C:\Trinidad\Trunk3\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\resource\TranslationsResourceLoader.java
Sending content:
C:\Trinidad\Trunk3\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\skin\provider\BaseSkinProvider.java
Sending content:
C:\Trinidad\Trunk3\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\renderkit\core\CoreRenderingContext.java
Sending content:
C:\Trinidad\Trunk3\trinidad-api\src\main\java\org\apache\myfaces\trinidad\skin\SkinFactory.java
Completed: At revision: 1547514
> unnecessary use of FacesContext in SkinProvider API
> ---------------------------------------------------
>
> Key: TRINIDAD-2433
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2433
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Skinning
> Affects Versions: 2.1.0-core
> Reporter: Anand V Nath
> Priority: Minor
> Fix For: 2.1.1-core
>
> Attachments: jira-2433-new.patch, jira-2433.patch
>
>
> SkinProvider API uses FacesContext in its methods. All that is done inside
> the API is to extract the ExternalContext. So it is sufficient to pass
> ExternalContext to the API. Though this is a public API change, the
> SkinProvider API is introduced recently and not widely used. This gives us a
> chance to correct the API now.
> Proposed change:
> - public Collection<SkinMetadata> getSkinMetadata(FacesContext context)
> + public Collection<SkinMetadata> getSkinMetadata(ExternalContext context)
> {
> return Collections.emptyList();
> }
> - public abstract Skin getSkin(FacesContext context, SkinMetadata
> skinMetadata);
> + public abstract Skin getSkin(ExternalContext context, SkinMetadata
> skinMetadata);
> and the related internal API changes.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
