Hi,
I uploaded "TRINIDAD-2444_Patch_Over_Trunk.patch", this is the patch file over Trinidad trunk for this issue. One of the
developers with write permission, please commit this patch, or pass on review comments if you have any.
https://issues.apache.org/jira/browse/TRINIDAD-2444
Thanks,
Prakash
-------- Original Message --------
Subject: [jira] [Updated] (TRINIDAD-2448) Optimize
ChangeManager.createDocumentChange() implementation
Date: Fri, 24 Jan 2014 01:07:38 +0000 (UTC)
From: Prakash Udupa (JIRA) <[email protected]>
Reply-To: MyFaces Development <[email protected]>
To: [email protected]
[
https://issues.apache.org/jira/browse/TRINIDAD-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Prakash Udupa updated TRINIDAD-2448:
------------------------------------
Status: Patch Available (was: Open)
Optimize ChangeManager.createDocumentChange() implementation
------------------------------------------------------------
Key: TRINIDAD-2448
URL: https://issues.apache.org/jira/browse/TRINIDAD-2448
Project: MyFaces Trinidad
Issue Type: Improvement
Affects Versions: 2.1.0-core
Reporter: Prakash Udupa
Attachments: TRINIDAD-2448_over_trunk.patch
Original Estimate: 1h
Remaining Estimate: 1h
Currently the implementation of org.apache.myfaces.trinidad.change
ChangeManager.createDocumentChange( ComponentChange change) does not account
for fact that the supplied ComponentChange implementation can also be
implementing DocumentChange. Improvement is to do this check first, type cast
the supplied component to DocumentChange and return.
There are several ComponentChange implementations in Trinidad that actually
also implement DocumentChange, so this is common usecase.
Currently clients need to do this check outside of this call, which can be
moved in here.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
