[ 
https://issues.apache.org/jira/browse/TRINIDAD-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017977#comment-14017977
 ] 

Venkata Guddanti commented on TRINIDAD-2445:
--------------------------------------------

The Filter is changing the behavior. It was previously the exception handler 
only for trinidadad AJAX and JSF 2.0 AJAX requests, when the exceptions happen 
outside the JSF lifecycle or for unhandled exceptions. Now it is the exception 
handler for all kinds of custom AJAX implementations. Reverting it back 
isPartialRequest = facesContext.getPartialViewContext().isAjaxRequest(); to 
isPartialRequest = CoreRenderKit.isPartialRequest(externalContext);.

We need a separate JIRA where the exception hander can be installed. It will 
have a boolean handleException(..) that will allow it to plug in an exception 
handler for exceptions that happen outside the JSF lifecycle or for unhandled 
exceptions.

> Prevent exceptions from propagating out of the ServletFilter
> ------------------------------------------------------------
>
>                 Key: TRINIDAD-2445
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2445
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Infrastructure
>    Affects Versions: 2.1.1-core
>            Reporter: Arjun Vade
>            Assignee: Jeanne Waldman
>             Fix For: 2.1.1-core
>
>         Attachments: 17191718.patch
>
>
> Any exceptions from the Trinidad code that runs before JSF lifecycle that 
> propagates to application server layer may result in the end user not seeing 
> a meaningful error message in UI.
> Solution: Trinidad code that runs before the JSF lifecycle shouldn't allow 
> exceptions to propagate out of the ServletFilter.
> The fix is simply to add code to our various ServletFilters to trap the 
> errors at that point before the errors propagate out.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to