[
https://issues.apache.org/jira/browse/MYFACES-3941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leonardo Uribe resolved MYFACES-3941.
-------------------------------------
Resolution: Fixed
Fix Version/s: 2.2.7
2.1.17
Ok, now I get it. It looks like isFaceletCached(...) is never called, but it
should work, so I have fixed it.
Thanks to Thomas Timbul for provide this patch
> FaceletCacheImpl#isFaceletCached(URL) always returns false
> ----------------------------------------------------------
>
> Key: MYFACES-3941
> URL: https://issues.apache.org/jira/browse/MYFACES-3941
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 2.1.16, 2.2.6
> Reporter: Thomas Timbul
> Assignee: Leonardo Uribe
> Priority: Minor
> Fix For: 2.1.17, 2.2.7
>
>
> Correct definition should be:
> {code:title=org.apache.myfaces.view.facelets.impl.FaceletCacheImpl}
> public boolean isFaceletCached(URL url)
> {
> return _facelets.containsKey(url.toString());
> }
> {code}
> The facelets map {{_facelets}} is actually declared as:
> {code}
> private Map<String, DefaultFacelet> _facelets;
> {code}
> For obvious reasons the current implementation will, in effect, always return
> false.
> I don't know if a null check might be appropriate, i.e.
> {code:title=org.apache.myfaces.view.facelets.impl.FaceletCacheImpl}
> public boolean isFaceletCached(URL url)
> {
> return url!=null && _facelets.containsKey(url.toString());
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
