[ 
https://issues.apache.org/jira/browse/MYFACES-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16333025#comment-16333025
 ] 

Eduardo Breijo commented on MYFACES-4190:
-----------------------------------------

I forgot to do a clean, so the auto-generated classes in the implementation 
were not being updated. After doing the clean the auto-generated classes in the 
implementation were updated (no setter methods for onselect attribute in the 
classes that don't need it anymore), I started getting the following error when 
driving a request to the jsp page that has the onselect attribute:

org.apache.jasper.JasperException: /passthroughtest.jsp (line: [18], column: 
[12]) Attribute [onselect] invalid for tag [selectManyListbox] according to TLD 
org.apache.jasper.compiler.DefaultErrorHandler.jspError(DefaultErrorHandler.java:42)
 org.apache.jasper.compiler.ErrorDispatcher.dispatch(ErrorDispatcher.java:292) 
org.apache.jasper.compiler.ErrorDispatcher.jspError(ErrorDispatcher.java:115) 
org.apache.jasper.compiler.Validator$ValidateVisitor.checkXmlAttributes(Validator.java:1268)
 org.apache.jasper.compiler.Validator$ValidateVisitor.visit(Validator.java:881) 
org.apache.jasper.compiler.Node$CustomTag.accept(Node.java:1544)

 

So I noticed that myfaces_taglib.tld is updated as well with the patch I 
provided, so that's why it is complaining about, because onselect is no longer 
in the TLD file for selectManyListBox.

 

On the other hand, Mojarra seems to have "onselect" defined in the TLD for the 
classes that we don't need it anymore, and they have their setter methods in 
the implementation as well.

 

I'm not sure if my patch is what we really need here, or if it just needs some 
additions to what I did. Maybe we need to do something in the renderer?

> Remove onselect attribute from SELECT elements
> ----------------------------------------------
>
>                 Key: MYFACES-4190
>                 URL: https://issues.apache.org/jira/browse/MYFACES-4190
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-372
>    Affects Versions: 2.3.0-beta
>            Reporter: Eduardo Breijo
>            Assignee: Eduardo Breijo
>            Priority: Major
>         Attachments: MYFACES-4190.patch
>
>
> According to JSF 2.3 spec issue 
> [https://github.com/javaee/javaserverfaces-spec/issues/1113] we need to 
> remove the onselect attribute from 
> h:selectOneMenu/h:selectManyMenu/h:selectOneListbox/h:selectManyListbox.
> I have tested on Mojarra 2.3 and they don't actually render the onselect 
> attribute.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to