lofwyr14 commented on a change in pull request #2: Tobago 1589
URL: https://github.com/apache/myfaces-tobago/pull/2#discussion_r171195751
##########
File path:
tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java
##########
@@ -132,13 +139,86 @@ public void decode(final FacesContext facesContext,
final UIComponent component)
}
RenderUtils.decodedStateOfTreeData(facesContext, sheet);
+ decodeSheetAction(facesContext, sheet);
+ decodeColumnAction(facesContext, columns);
/* this will be done by the javax.faces.component.UIData.processDecodes()
because these are facets.
for (UIComponent facet : sheet.getFacets().values()) {
facet.decode(facesContext);
}
*/
}
+ private void decodeColumnAction(final FacesContext facesContext,
List<AbstractUIColumnBase> columns) {
Review comment:
please use final as parameter qualifier
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
