[ 
https://issues.apache.org/jira/browse/MYFACES-4203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414950#comment-16414950
 ] 

Paulo Cristovão de Araújo Silva Filho commented on MYFACES-4203:
----------------------------------------------------------------

[~tandraschko], I`ve found an issue with the implementation: when NOT using 
begin/end model and given a null list, the impl throws an exception complaining 
about empty models. Made a new patch, prepared over current 2.3.x branch, 
fixing it. Now that I've seen how you made it, added unit test too. As I was 
not sure if I should reopen this issue or create a new one, here it is: 
[^patch_4203_nullmodel.diff]

> UIRepeat begin+end doesn't work correctly
> -----------------------------------------
>
>                 Key: MYFACES-4203
>                 URL: https://issues.apache.org/jira/browse/MYFACES-4203
>             Project: MyFaces Core
>          Issue Type: Bug
>    Affects Versions: 2.3.0
>            Reporter: Paulo Cristovão de Araújo Silva Filho
>            Assignee: Thomas Andraschko
>            Priority: Major
>             Fix For: 2.3.1
>
>         Attachments: index.xhtml, myfaces-spec1102-1.diff, 
> patch_4203_nullmodel.diff
>
>
> As described at [https://github.com/javaee/javaserverfaces-spec/issues/1102] 
> , UIRepeat should behave as c:forEach when given a begin and an end 
> parameter, without any model.
> Mojarra impl already does that, as the deployment of the attached xhtml shows 
> (althought it has some issues of her own on rerender).
> There's also a patch built on 2.3.0 version. Due to time restrictions, I 
> couldn't make a unit test for the change, but the patched myfaces versions 
> passes on all other tests and behaves on other jsf projects. Hope you can 
> grab the changes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to