[jira] [Commented] (MYFACES-4237) [perf] Performance update when checking for duplicate ids

[Paul Nicolucci (JIRA)]

    [ 
https://issues.apache.org/jira/browse/MYFACES-4237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16510395#comment-16510395
 ] 

Paul Nicolucci commented on MYFACES-4237:
-----------------------------------------

It's called in the following context:


{code:java}
// Make sure the client IDs are unique per the spec.
            
            if (context.isProjectStage(ProjectStage.Production))
            {
                if 
(CHECK_ID_PRODUCTION_MODE_AUTO.equals(getCheckIdProductionMode(context)))
                {
                    
CheckDuplicateIdFaceletUtils.checkIdsStatefulComponents(context, view);
                }
                else if 
(CHECK_ID_PRODUCTION_MODE_TRUE.equals(getCheckIdProductionMode(context)))
                {
                    CheckDuplicateIdFaceletUtils.checkIds(context, view);
                }
            }
            else
            {
                CheckDuplicateIdFaceletUtils.checkIds(context, view);
            }
{code}

So can be enabled in production, and by default 
org.apache.myfaces.CHECK_ID_PRODUCTION_MODE is "auto".


> [perf] Performance update when checking for duplicate ids
> ---------------------------------------------------------
>
>                 Key: MYFACES-4237
>                 URL: https://issues.apache.org/jira/browse/MYFACES-4237
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: JSR-372
>    Affects Versions: 2.2.12, 2.3.1
>            Reporter: Paul Nicolucci
>            Assignee: Paul Nicolucci
>            Priority: Minor
>             Fix For: 2.2.13, 2.3.2
>
>
> In 
> org/apache/myfaces/view/facelets/compiler/CheckDuplicateIdFaceletUtils.java 
> we currently do the following:
> {code:java}
> if (existingIds.contains (id)) {
> ....
> }
> {code}
> We can increase performance by doing the following:
> {code:java}
> if (!existingIds.add (id)) {
> ....
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)