tandraschko commented on issue #27: MYFACES-4266: Ajax update fails due to invalid characters in response XML (DoS) URL: https://github.com/apache/myfaces/pull/27#issuecomment-441182397 cool :D I'm a just a bit unsure... The current version will work but maybe it's a bit "unattractive". 1) I think we should overwrite all #write methods, to cover 100% all cases?! Probably also writeText? 2) all #write methods should call the same super.write - currently the write(String) calls super.write(char[]) to avoid confusion (and maybe but unlikely bugs) JFYI: you can also use a for-each loop when looping over arrays, we just avoid it on ArrayLists, to avoid a iterator instance (ArrayLists are used for component lists e.g. and the component tree is traversed very often)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
