[
https://issues.apache.org/jira/browse/MYFACES-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16699625#comment-16699625
]
Thomas Andraschko edited comment on MYFACES-4269 at 11/26/18 10:10 PM:
-----------------------------------------------------------------------
[~eduardobreijo]
You introduced another cache "isFacesServlet" some time ago. I cached now a
level above the FacesServletRegistration.
Could you please review and also do some tests?
It was really a slow part...
I also wonder why a fallback to other servlets was done in
createMappingFromServletRegistration. I don't think we should map requests from
other servlet to a JSF request. (Mojarra also only handles FacesServlet AFAIK)
Will also check another slow part now.
was (Author: tandraschko):
[~eduardobreijo]
You introduced another cache "isFacesServlet" some time ago. I cached now a
level above the FacesServletRegistration.
Could you please review and also do some tests?
It was really a slow part...
I also wonder why a fallback to other servlets was done in
createMappingFromServletRegistration. I don't think we should map requests from
other servlet to a JSF request.
Will also check another slow part now.
> [perf] getServletRegistrations is slow and not cached
> -----------------------------------------------------
>
> Key: MYFACES-4269
> URL: https://issues.apache.org/jira/browse/MYFACES-4269
> Project: MyFaces Core
> Issue Type: Improvement
> Affects Versions: 2.3.2
> Reporter: Thomas Andraschko
> Priority: Major
> Attachments: MYFACES-4269.patch
>
>
> seems like servletContext#getServletRegistrations does internal always a new
> lookup instead of caching it (on tomcat 9.x)
> we can simple cache the FacesServletRegistration
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
