Please dont use the release vote thread for such topics. You can easily
disable it via org.apache.myfaces.USE_LAMBDA_METAFACTORY=false. Also it's
just a Milestone release.

Create a issue and provide a test project (like a forked primefaces-test),
so i can fix it for the next milestone.

Am Mi., 1. Juli 2020 um 10:35 Uhr schrieb Vicente Rossello <
[email protected]>:

> Hi,
>
> I just tested it.
>
> I've had a few problems with methodHandles (maybe those were not correct
> before, but the problem starts with method handles).
>
> 1.- We were checking in some case a property class name from within EL and
> that does not work with methodHandles. See
> https://stackoverflow.com/questions/10314214/instanceof-check-in-el-expression-language
>  . We can workaround using of:isIntance (which is probably a better
> solution).
> 2.- We were using java.awt.Dimension to pass image size as 1 attribute and
> that fails with  java.lang.IllegalAccessException: module java.desktop
> does not open java.awt to unnamed module We can work around this with
> --add-opens=java.desktop/java.awt=ALL-UNNAMED
> 3.- #{someTimezone.ID} also fails with module java.base does not open
> sun.util.calendar to unnamed module   , not sure how to open this one
> 4.- I really don't understand this one but I have:
>
> <p:inputText readonly="true" style="width: 400px" id="questionnaire-url" 
> styleClass="questionnaire-url" 
> value="#{Faces:getRequestBaseURL().concat('questionnaire/')}" />
>
> fails with:
>
> java.lang.NullPointerException: Cannot invoke 
> "org.apache.myfaces.core.api.shared.lang.LambdaPropertyDescriptor.getPropertyType()"
>  because the return value of 
> "org.apache.myfaces.el.resolver.LambdaBeanELResolver.getPropertyDescriptor(Object,
>  Object)" is null
>       at 
> org.apache.myfaces.el.resolver.LambdaBeanELResolver.getType(LambdaBeanELResolver.java:54)
>       at javax.el.CompositeELResolver.getType(CompositeELResolver.java:92)
>       at 
> org.primefaces.el.InterceptingResolver.getType(InterceptingResolver.java:67)
>       at org.apache.el.parser.AstValue.getType(AstValue.java:60)
>       at 
> org.apache.el.ValueExpressionImpl.getType(ValueExpressionImpl.java:174)
>
> base is: "http://localhost";
>
> property is "concat"
>
> If it's not inside an input text it does not fail (just #{
> Faces:getRequestBaseURL().concat('questionnaire/')}  )
>
> I understand that 1 to 3 are limitations of MethodHandles and the user
> should be responsible for handling those?
>
> Hope it's something useful.
>
> Best regards,
> Vicente.
>
> On Tue, Jun 30, 2020 at 2:12 PM Thomas Andraschko <
> [email protected]> wrote:
>
>> Hi,
>>
>> I was running the needed tasks to get the 2.3-next-M3 release of Apache
>> MyFaces core out.
>> It contains new features, performance improvements, bugfixes and provides 
>> compatibility with Quarkus 1.5.2.
>>
>> Please note that this vote concerns all of the following parts:
>>    1. Maven artifact group "org.apache.myfaces.core" v2.3-next-M3  [1]
>>
>> The artifacts were deployed on nexus repo [1] for binary and source packages.
>>
>> The release notes could be found at [4].
>>
>> Please take a look at the "2.3-next-M3" artifacts and vote! (see [3])
>>
>> Please note: This vote is "majority approval" with a minimum of three +1 
>> votes (see [2]).
>>
>> ------------------------------------------------
>> [ ] +1 for community members who have reviewed the bits
>> [ ] +0
>> [ ] -1 for fatal flaws that should cause these bits not to be released, and 
>> why..............
>> ------------------------------------------------
>>
>> Thanks,
>> Thomas
>>
>> [1] 
>> https://repository.apache.org/content/repositories/orgapachemyfaces-1162/org/apache/myfaces/core/
>> [2] http://www.apache.org/foundation/voting.html#ReleaseVotes
>> [3] 
>> https://repository.apache.org/content/repositories/orgapachemyfaces-1162/org/apache/myfaces/core/myfaces-core-assembly/
>> [4] 
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&version=12347873
>>
>>

Reply via email to