benkard opened a new pull request #110: URL: https://github.com/apache/myfaces/pull/110
Quarkus does not have passivation and its `BeanManager#isPassivatingScope` implementation therefore always returns `false`. `FlowScopeBeanHolder` ignores this and assumes that `@FlowScoped` is always passivating (which is presumably true everywhere but Quarkus). This makes attempts to use `@FlowScoped` beans fail with a `ClassCastException` during `ContextualStorage#getBeanKey`'s attempt to cast the passed bean to `javax.enterprise.inject.spi.PassivationCapable`. This PR changes `FlowScopeBeanHolder` to not assume that `@FlowScoped` is a passivating scope and to ask the `BeanManager` instead. This should not affect any CDI implementations other than Quarkus (since `BeanManager.isPassivatingScope(FlowScoped.class)` is expected to return `true` everywhere else), but I have not tested this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
