volosied edited a comment on pull request #120:
URL: https://github.com/apache/myfaces/pull/120#issuecomment-714775978
@tandraschko
Firstly, I apologize for the delay on this, but I finally spent some time
on this and here's what I found --
- I don't really see anything within MyFaces that matches the Namespace
changes done in Mojarra.
- No hits for
[NamespaceContext](https://docs.oracle.com/javase/8/docs/api/javax/xml/namespace/NamespaceContext.html?is-external=true)
in MyFaces.
- There doesn't appear to be any Namespace handing within the MyFaces
implementation. The only thing that matters from the faces-config declaration
is the
[version](https://github.com/apache/myfaces/blob/3.0.x/impl/src/main/java/org/apache/myfaces/config/impl/digester/DigesterFacesConfigUnmarshallerImpl.java#L55)?
I didn't experience any errors or warnings when just using **< faces-config
version="3.0" >**.
The code for handling the faces-config isn't very straightforward, but I saw
that the parsing is accomplished by
[DigesterFacesConfigUnmarshallerImpl](https://github.com/apache/myfaces/blob/3.0.x/impl/src/main/java/org/apache/myfaces/config/impl/digester/DigesterFacesConfigUnmarshallerImpl.java#L512)
which is called from
[here](https://github.com/apache/myfaces/blob/3.0.x/impl/src/main/java/org/apache/myfaces/config/DefaultFacesConfigurationProvider.java#L437).
Should I first implement something relating to the NamespaceContext, but
I'm not sure if it's necessary?
Last of all, I also don't think this PR needs the
impl/src/main/conf/META-INF/standard-faces-config-base.xml change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
