[ https://issues.apache.org/jira/browse/MYFACES-4408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399684#comment-17399684 ]
Thomas Andraschko commented on MYFACES-4408: -------------------------------------------- its just very old code, which was never migrated to junit4 or 5 API as long as the maven plugin runs them correclty, it doesnt matter for us but feel free to work on it, to migrate tests to junit4 or 5 > Test classes wich extends AbstractJsfConfigurableMockTestCase are running > with junit3 > ------------------------------------------------------------------------------------- > > Key: MYFACES-4408 > URL: https://issues.apache.org/jira/browse/MYFACES-4408 > Project: MyFaces Core > Issue Type: Bug > Components: JSR-372 > Affects Versions: 2.3-next-M6 > Environment: junit 4.13.2, myfaces-test 2.3-next-M6 > Reporter: Stanislav > Priority: Minor > > JUnit38ClassRunner is used for tests when test classes extends > AbstractJsfConfigurableMockTestCase. It is because > AbstractJsfConfigurableMockTestCase extends TestCase and there is check in > JUnit3Builder > {code:java} > public class JUnit3Builder extends RunnerBuilder { > @Override > public Runner runnerForClass(Class<?> testClass) throws Throwable { > if (isPre4Test(testClass)) { > return new JUnit38ClassRunner(testClass); > } > return null; > } boolean isPre4Test(Class<?> testClass) { > return junit.framework.TestCase.class.isAssignableFrom(testClass); > } > } > {code} > Is it correct, that jsf tests have to run with Junit 3? -- This message was sent by Atlassian Jira (v8.3.4#803005)