glynn29 commented on pull request #233: URL: https://github.com/apache/myfaces/pull/233#issuecomment-1072604934
Thank you for the feedback, I'm hoping my following explanation helps. Perhaps I should add the following as comments? This renderer actually handles two classes: UISelectBoolean and UISelectMany. We are merely trying to fix UISelectBoolean in this patch, and not UISelectMany at this time to try to keep merge requests small and focused. The single checkbox INPUT_ELEM for UISelectBoolean is opened in `encodeBegin()`, and closed in the `encodeEnd()`. The INPUT_ELEM for UISelectMany is left alone in `encodeEnd()`. In `renderCheckboxList()` for UISelectMany, it calls the single checkbox renderer `renderCheckbox()`. The additional branch to check for an instanceof UISelectMany leaves the the current behavior for writing the end element unchanged for this class. We can make changes to handle both classes in this patch, but we'd prefer to handle in a separate PR. We have tested this manually and it is passing the unit tests written in `HtmlCheckboxRendererTest`. Hopefully this clears things up. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
