volosied commented on code in PR #263:
URL: https://github.com/apache/myfaces/pull/263#discussion_r864132725
##########
impl/src/main/java/org/apache/myfaces/lifecycle/clientwindow/ClientConfig.java:
##########
@@ -198,7 +198,7 @@ public String getUserAgent(FacesContext facesContext)
/**
* Users can overload this method to define in which scenarios a request
should result
* in an 'intercepted' page with proper windowId detection. This can e.g.
contain
- * blacklisting some userAgents.
+ * blocklisting some userAgents.
Review Comment:
Hi @mkienenb, I see your point. I'd be happy to work with you to pick
another term as I'd prefer community consensus here for future consistency.
Possible choices are:
- Disallow list
- Deny list
- Restricted List
- any other suggestions
Alternatively, we could update or remove the comment here as `This can e.g.
contain blacklisting some userAgents.` could be worded better in general.
Perhaps, `This can be used to block some userAgents, for example.`
Let me know you thoughts. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
