melloware commented on code in PR #281:
URL: https://github.com/apache/myfaces/pull/281#discussion_r906804326
##########
impl/src/main/java/org/apache/myfaces/resource/TempDirFileCacheContractResourceLoader.java:
##########
@@ -229,20 +227,7 @@ protected void createTemporalFileVersion(FacesContext
facesContext, ResourceMeta
{
throw new FacesException("Unexpected exception while create
file:", e);
}
- finally
- {
- if (inputStream != null)
- {
- try
- {
- inputStream.close();
- }
- catch (IOException e)
- {
- // Ignore
- }
- }
- }
+ // Ignore
Review Comment:
Same?
##########
impl/src/main/java/org/apache/myfaces/config/impl/FacesConfigUnmarshallerImpl.java:
##########
@@ -179,18 +180,8 @@ public FacesConfigImpl getFacesConfig(InputStream in,
String systemId) throws IO
{
throw new FacesException(e);
}
- finally
- {
- try
- {
- in.close();
- }
- catch (IOException e)
- {
- // ignore silently
- }
- }
-
+ // ignore silently
Review Comment:
I don't know if you need these trailing comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
