Hi Werner, great to hear that you are back and hope you are fine again :)
IMO the reimplementation is great and improves the maintainability a lot for the future. I would personally only push it in the master (4.0 / jakarta.*), all other branches are "stable" and we should not touch them. Therefore we are totally fine to only support IE11+. So it would be great if you can also remove some older IE hacks like https://github.com/werpu/jsfs_js_ts/blob/master/src/main/typescript/impl/xhrCore/RequestDataResolver.ts#L113 Also it would be great if you can further improve readability. For me its absolutely mandatory that all code is directly in MyFaces and compiles with Maven somehow. So it would also be great if you could only use a minimal of your TS mona-dish lib, so we are as clean and minimalistic as possible. Best regards, Thomas Am Di., 6. Sept. 2022 um 10:21 Uhr schrieb Werner Punz < [email protected]>: > I will add a short summary on what we have: > > The project atm is hosted on github and basically 100% my code (although > split into 2 projects) > it is 100% implemented in typescript and fortified with a ton of unit > tests. I have yet given i did not work on it for quite some time, check the > coverage percentage, but it is high. > > Downside is, I cut off a ton of old browser support. I think IE11 is still > supported but nothing below. > The code is way more readable although some parts still can be improved. > Maintainability was Prio #1 something the old code which had to support a > ton of legacy browsers did not have. > > Downside is, it is 100% typescript, so we need to merge that into the > myfaces base one way or the other but there is no way to avoid an npm build > step if we drag in the package via npm or on typescript level. > Another option simply would be to fetch the compiled sources but that > leaves out the connection to the original sources entirely (except for the > sourcemaps), which I would not prefer. > > The implementation level is atm jsf 2.x i have to check whether we need > siginficant extensions for 3 when I stalled my work the status was the js > parts did not change. > (one thing I have on my plan for the next few days) > > > Werner > > > Am Di., 6. Sept. 2022 um 10:13 Uhr schrieb Werner Punz < > [email protected]>: > >> Hi Sorry for my long absence. >> >> Thing is I had severe health problems last year with a disc prolapse >> becoming acute, and had a ton of private stuff on my back this year on top >> of my job. >> However I have now picked up the work on the JSF,js Typescript again. >> I have yet to check the latest specs of JSF given i was out of the loop >> for a year if anything significant needs to be added. >> The Scripts themselve work and have been in usage in Tobago for quite a >> while. >> I am just asking whether we want them to add to myfaces or not. If yes >> then I would start the work to add them as a build option. >> >> But I want the community decide on this. >> >> Lets start a discussion. >> >> Werner >> >> >>
