Hi, I checked the integration tests. I think I will spend an extra time if possible next week to overhaul them. Following they are based anyway on my github integration tests, but atm do not work due to dependencies issues.
My github integration tests run fine, but I want to overhaul them as well to get rid of the last of the old codebase there as well if possible next week. So once done with those I will change the codebase in the integration tests for ajax as well. For me it is fine for now not to have them working in myfaces, all 136 unit tests and 19 integration tests I have on github pass atm with a standard myfaces installation, and tobago works as well with the integrated version. This is fine enough for me for now. So I would be ready to commit. The question is I want people in the mailing list to test the codebase before we are going with it into the main branch, I do not want to risk to damage the build process or working projects by sending off such a severe change into RC4 So how about I push everything into a temporary new branch like feature/RC4_AJAX or something like it, which we will delete after merge. That way everyone can test out and review the code, and as soon as the mailinglist gives the ok, we will merge back into main. Am Mi., 28. Sept. 2022 um 17:56 Uhr schrieb Werner Punz < [email protected]>: > Hi last mail for today on this issue. I have the integration now fully > running, the last item pending are the Arquilian based integration tests. I > will check them tomorrow and see whether we still need all of them. We now > have quite extensive coverage on source level via Mocha based unit tests > (136 tests so far). If all goes well, I should have a commit ready for > Friday or Monday. > > The question is, the changes are quite extensive. > I dropped basically the entire old scripts, changed stuff in the resource > handlers to get el resolution and mapping support in and also changed the > client build files, adding the Maven client plugin and node with it and a > new jsdoc generation via webpack. > > Shall I commit it once I am ready, or simply drop a patch for now so that > others can test, before my commit? Also a short lived testing branch would > be possible. I am open for anything. But given we are already in release > candidate status for 4.0 I would prefer to have other people testing it on > in myfaces before doing the final commit in main. > >> >>>
