Yep why not just submit a PR in a feature branch so we can code review
it on GitHub like a normal PR?
On 9/29/2022 5:57 AM, Werner Punz wrote:
Hi I wrote it before, but in the never ending list of replies it went
under.
I am basically commit-ready for the updated code. I will skip the work
on the integration tests now
given they do not work atm anyway due to dependency issues and they
are based on my working github ones anyway.
(I will revisit this part next week)
However, given that I did a ton of changes in the resource loaders,
dropped literally all old files, changed the pom quite a bit and
introduced
the maven client plugin which triggers node, instead of running
straight maven plugins, I would love to have a proper review and
testing from the community, before merging.
So my proposal is, I will push the changes for now into a feature
branch, if possible, so that anyone can test the build and the new
codebase who wants to, and after a period of feedback time when
everyone is happy we merge it into the 4.0 release candidates.
Any comments on that?
Werner
