werpu commented on PR #325:
URL: https://github.com/apache/myfaces/pull/325#issuecomment-1262201933
Yes I started with it 2019, but given customer projects, covid and months
of rehab due to a spine injury it took longer than expected.
I reviewed my readmes today, and there was the sentence, that I expect a
final version late 2020, oh boy I was wrong.
Just a short explanation to the build process, the code is now entirely
hosted on myfaces the build dependency for the client less so. But I did
not want to omit the path from the other github project into myfaces, since
it contains a self running version and a 2.3 jsf version. So I pull
basically per user command, not build command, the code via an npm package
in and then copy the sources into myfaces. The rest is a standard npm
webpack build with all the needed dependencies triggered via the client
plugin.
The final file then lands directly in the target folder, also the jsdoc
profile still is intact, it is now just not generated by our jsdoc
generators anymore but the webpack plugin.
(mojarra seems to use the same engine, as it seems, given the html layout
of the jsdoc specs)
I guess apache has already some npm caches in place, because we are not the
first project to do so.
Also another thing, mapping files now work, but wont work out of the box
given how they are loaded, following trick does it:
<!-- Faces Servlet Mapping -->
<servlet-mapping>
...
<!-- enable the internal map files, we use a marker extension
called mf_ap, the file itself ends with map -->
<!-- if you do not want to enable map files, simply remove this
the line with the mf_map mapping -->
<url-pattern>*.mf_map</url-pattern>
</servlet-mapping>
This adds a special entry which then should load the mapping files, that
way you can debug directly into the ts files if you want to.
Thats the reasony why i was able to kill the 5 different builds for
debugging.
Werner
Am Do., 29. Sept. 2022 um 14:13 Uhr schrieb Melloware <
***@***.***>:
> Nice work on this! Lots to review here but looking good from what I see so
> far.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/myfaces/pull/325#issuecomment-1262190568>, or
> unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AAEBQ43DJLT5PZFQQUW75DLWAWBWZANCNFSM6AAAAAAQYWJQ2M>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
